Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMP: method ad hoc for max user input #588

Closed
wants to merge 1 commit into from
Closed

IMP: method ad hoc for max user input #588

wants to merge 1 commit into from

Conversation

kodaline
Copy link
Contributor

Improvement for #558

Added ad hoc method to manage very long input messages

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kodaline
IMP: method ad hoc for max user input
f604cd5 
- cheshire_cat.py: new method store_long_input_to_declarative
to deal with very long inputs

improvement of issue cheshire-cat-ai#558
@pieroit
Copy link
Member

pieroit commented Dec 7, 2023

This PR can be updated to be in class StrayCat instead of ChehsireCat
Should I close this?

@kodaline
Copy link
Contributor Author

kodaline commented Dec 7, 2023 •
edited
Loading

This PR can be updated to be in class StrayCat instead of ChehsireCat Should I close this?

Ok, I will update it as you say @pieroit
Should I open a new PR?

@kodaline kodaline mentioned this pull request Dec 7, 2023
Merged
7 tasks
@kodaline
Copy link
Contributor Author

kodaline commented Dec 7, 2023

@pieroit you can close this one, adjusted in #612

@pieroit pieroit closed this Dec 7, 2023
@kodaline kodaline deleted the develop_issue_558_improved branch January 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kodaline @pieroit